Add Amazon Corretto distribution

[WtfJoke]

Description:
Add feature to allow setup-java to run with major versions of available amazon correttos binaries.
The available (major) versions are fetched from https://corretto.github.io/corretto-downloads/ (from the following json: https://corretto.github.io/corretto-downloads/latest_links/indexmap_with_checksum.json).

I've tested it also with a random java project here: Workflow-run
Related issue:
Fixes #68

Check list:

• Mark if documentation changes are required.
• Mark if tests were added or updated to cover the changes.

[dmitry-shibanov]

Hello @WtfJoke. Thank you for your pull request. I have some questions:

• Do Amazon Corretto binaries have unstable versions ?
• Do Amazon Corretto binaries have jre versions

[WtfJoke]

Hi @dmitry-shibanov

I'll try to answer the questions :)

• Do Amazon Corretto binaries have unstable versions ?

Not that I know of (at least the json, doesnt provide anything and I didnt found anything else documented).

• Do Amazon Corretto binaries have jre versions

Not many, but they do (for example they provide jre 8 for windows)

Is there a particular reason for your question (in order for me to improve my pr in any way)?

[dmitry-shibanov]

Hello @WtfJoke. Thank you for your responses. Could you please add support for jre versions ?

[WtfJoke]

Hi @dmitry-shibanov

jre versions are already supported, see this test case for example:

setup-java/__tests__/distributors/corretto-installer.test.ts

Line 54 in 411c86b

[{ version: '18', architecture: 'x64', packageType: 'jre', checkLatest: false }, 'windows', 1]

Or did I missunderstand you?

[dmitry-shibanov]

Thank you @WtfJoke. Could you please include this test case to e2e ?

[WtfJoke]

Sure, I've included it in the e2e-versions workflow (they provide only jre releases currently for windows in version 8).

As a small bonus 🎈 I've also changed the version of job setup-java-custom-package-type to java version 17 (instead of 16), so temurin doesnt need to be excluded anymore as they provide JRE releases for LTS versions and we have some more tests 😄

[dmitry-shibanov]

Thank you.

[btsteve]

Is there a way to test the unreleased version?

[WtfJoke]

@btsteve
Yes there is, you can use my fork + branch in your worfklow like this (until it is merged):

jobs:  
  build:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v1
      - name: Install JDK 11
        uses: WtfJoke/setup-java@addCorretto
        with:
          distribution: corretto
          java-version: 11

Or here the full workflow yaml, I've tested with

[WtfJoke]

Hey @dmitry-shibanov
Just rebased the commits to the latest main and resolved the conflicts.
As I know that you are probably busy, I've just wanted to ask gentle if there is some kind of ETA when you review/merge this PR?

Thanks a bunch!

[mu88]

@WtfJoke: can I also install Corretto on a Windows agent (runs-on: windows-latest)? If so, can I somehow already test your changes in one of my GitHub Actions? Or do I need to wait until it is released?

[WtfJoke]

@WtfJoke: can I also install Corretto on a Windows agent (runs-on: windows-latest)? If so, can I somehow already test your changes in one of my GitHub Actions? Or do I need to wait until it is released?

@mu88 Yes, its also possible in windows.
You can already test it by using WtfJoke/setup-java@addCorretto instead of actions/setup-java@v3

See the example (there is also a full workflow yaml linked) in the comment above (you just can replace ubuntu with windows as you've already have written):

#312 (comment)

If you still need help, feel free to post your workflow.

[TomBeckett]

For what its worth I've been using @WtfJoke's fork for a while now and seems to be working great!

@dmitry-shibanov Is this good to merge? Is there anything in particular I should test?

[dmitry-shibanov]

Hello @WtfJoke. Could you please sync with the main ? I've tested your changes and it works as expected.

[WtfJoke]

Hi @dmitry-shibanov
I've rebased my branch with the latest main and fixed the conflicts. Great that you were able to test it.

Looking forward for the merge/release 😄 🚀

[aaiezza]

Great work!

Does anyone have an example of how to use this now?

[spaletta]

@aaiezza See https://github.com/actions/setup-java#usage