Bumping actions/core and actions/github dependencies for GHES#69
Merged
Conversation
pjquirk
changed the title
ericsciple
reviewed
May 12, 2020
ericsciple
approved these changes
May 12, 2020
Contributor
|
What is the benefit of changing from dist/index to lib/index? Not sure I understand the point, or why the lib/ file is so much smaller than the dist/ one... |
Contributor
Author
|
@dakale It's mainly to distinguish the outputs of |
Contributor
|
Thanks, that makes sense, as does ignoring checking in lib/ |
dakale
approved these changes
May 12, 2020
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for running against GHES by using v2.2.0 of
@actions/github. I also bumped@actions/coreto 1.2.4 to fix error handling in the case anErrortype is thrown rather than astring.The build/pack steps seemed unreliable, so I updated the Typscript config to build to
./lib, andnccwill then build out of that (this matches other actions like actions/stale).Tested by pushing this version of the action to an "actions" org on the GHES instance. I also needed to set
NODE_TLS_REJECT_UNAUTHORIZED = 0temporarily in the action to get around my self-signed (or otherwise not trusted) server cert.