add benchmark with sequential reading and parallel processing#5
Merged
bogcon merged 1 commit intoactforgood:mainfrom Jun 20, 2023
Merged
add benchmark with sequential reading and parallel processing#5bogcon merged 1 commit intoactforgood:mainfrom
bogcon merged 1 commit intoactforgood:mainfrom
Conversation
Collaborator
|
Hi @oliverpool I tried to catch only the I/O (reading) improvement on a bigger file, |
Contributor
Author
|
Thanks! Maybe it would be worth mentioning in the description/readme that this package is mostly useful for IO-bound workloads (since as the newly added benchmarks shows, when the CPU is the bottleneck, the stdlib csv reader is fast enough :) |
Collaborator
|
I added this note in the readme. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This package has an interesting approach of splitting the file. However I think that usual csv processing is CPU-bound and not IO-bound.
This is reflected in the benchmarks with the
fakeProcessRowfunction.I created a benchmark with uses the stdlib csv reader and spawns multiple workers for record processing:
Benchmark50000Rows_50Mb_withGoCsvReaderReadOneByOneProcessParalell.The result is not far from
Benchmark50000Rows_50Mb_withBigCsvReader:Type of change
Checklist:
Contributor License Agreement
By submitting this pull request, I confirm that my contribution is made under the terms of project's license.