Skip to content

[imp] repo.collect_prs_info allow to pass custom merges#91

Merged
sbidoul merged 1 commit into
acsone:masterfrom
simahawk:imp-collect
Mar 21, 2025
Merged

[imp] repo.collect_prs_info allow to pass custom merges#91
sbidoul merged 1 commit into
acsone:masterfrom
simahawk:imp-collect

Conversation

@simahawk

Copy link
Copy Markdown
Contributor

Very handy to be able to feed it with custom PRs info. Example: provide a parsed version of shell_after_commands containing PR patches.

@simahawk

Copy link
Copy Markdown
Contributor Author

@sbidoul time to cleanup? :)

Run actions/setup-python@v4
Installed versions
  Version 3.7 was not found in the local cache
  Error: The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04.
  The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

@sbidoul

sbidoul commented Mar 21, 2025

Copy link
Copy Markdown
Member

Yes we can drop 3.7 and 3.8, and add 3.12 and 3.12.

@simahawk

Copy link
Copy Markdown
Contributor Author

#92

Very handy to be able to feed it with custom PRs info.
Example: provide a parsed version of shell_after_commands containing PR patches.
@simahawk

Copy link
Copy Markdown
Contributor Author

Rebased

@sbidoul sbidoul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it does not harm :)

Keep in mind that this project does not have a documented public API beyond the CLI.

@simahawk

Copy link
Copy Markdown
Contributor Author

I take the risk 😜

@sbidoul
sbidoul merged commit 582d365 into acsone:master Mar 21, 2025
@simahawk

Copy link
Copy Markdown
Contributor Author

@sbidoul would it be possible to have a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants