Skip to content

ACRL-417 // Remove tomlq, use awk to parse version#3

Open
ogorman89 wants to merge 1 commit intomainfrom
ian/remove-tomlq
Open

ACRL-417 // Remove tomlq, use awk to parse version#3
ogorman89 wants to merge 1 commit intomainfrom
ian/remove-tomlq

Conversation

@ogorman89
Copy link
Copy Markdown

Related Links

Description and Rationale

  • Ran into a silent error when tomlq is not installed on the machine
  • Caused some mild but confusing errors in the SimKube repo when trying to regenerate templated kustomize files via our make kustomize target
  • I think we can just use awk to parse the version from Cargo.toml instead of using an additional dependency

How

  • remove the tomlq call and substitute an awk command
  • add a basic guard if the APP_VERSION cannot be identified, this will prevent future silent failures

Test Steps

  • I tested it manually invoking it in the shell and via the makefile (on SimKube branch I was working on)

Other Notes

  • If you would prefer we keep tomlq I could just document it somewhere

@ogorman89 ogorman89 self-assigned this Apr 27, 2026
@ogorman89 ogorman89 added the enhancement New feature or request label Apr 27, 2026
@linear
Copy link
Copy Markdown

linear Bot commented Apr 27, 2026

@ogorman89 ogorman89 requested a review from drmorr0 April 27, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant