[dxsa][mlir] Add bufinfo, resinfo, samplepos, sampleinfo#214
Conversation
|
I based this patch on #182 because it needed the extended instructions support. However, it has regular unary and binary instructions that are not yet implemented in that branch, so I had to re-add the implementation so that I could run the tests. These extra function should be removed/updated to their versions in the main branch when merging with it. |
asavonic
force-pushed
the
dxsa-mlir-sampler
branch
2 times, most recently
from
cc0bf04 to
161d8b2
Compare
kuilpd
force-pushed
the
kuilpd/dxsa-mlir-bufinfo-resinfo-samplepos-sampleinfo
branch
from
19f5609 to
8020ab3
Compare
|
@asavonic |
This patch also changes `verifyInstructionLength` so that it fails only if parsed operands length is greater than the specified instruction length in the opcode, and it skips the unparsed tokens if the specified instruction length is longer than parsed operands. This matches the behavior of `dxbc2dxil`, which doesn't check if there are unparsed tokens left, and simply moves further to parse tokens past the specified instruction length. `FXC` can output `samplepos` with an extra token in the end, not sure about other instructions.
2 participants
Add resource instructions
bufinfo,resinfo,samplepos,sampleinfo.This patch also changes
verifyInstructionLengthso that it fails only if parsed operands length is greater than the specified instruction length in the opcode, and it skips the unparsed tokens if the specified instruction length is longer than parsed operands. This matches the behavior ofdxbc2dxil, which doesn't check if there are unparsed tokens left, and simply moves further to parse tokens past the specified instruction length.FXCcan outputsampleposwith an extra token in the end, not sure about other instructions.