test: add unit tests for PatternDetector (closes #252)#255
Open
acailic wants to merge 1 commit into
Open
Conversation
45 tests covering Pattern.to_dict(), helper metrics, and all five detect_* methods including severity thresholds, zero-baseline edge cases, and detect_all_patterns grouping/sorting behaviour. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_pattern_detector.pywith 45 unit tests covering zero-coveragePatternDetectorPattern.to_dict()roundtrip and all expected keys_calculate_average_error_rateand_calculate_tool_failure_ratehelpers including empty and zero-baseline edge casesdetect_*methods: error rate trends, tool failure frequency, new failure modes, confidence drops, anddetect_all_patterns(grouping by agent, critical-before-warning sort, baseline-too-small guard)Closes #252
Test plan
python3 -m pytest -q tests/test_pattern_detector.py→ 45 passed🤖 Generated with Claude Code