test: add unit tests for PatternDetector (zero coverage)#254
Open
acailic wants to merge 1 commit into
Open
Conversation
Adds tests/test_pattern_detector.py covering Pattern.to_dict, helper methods, and all detection methods with severity escalation and edge cases (empty inputs, zero baselines, threshold boundaries). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #252
Summary
tests/test_pattern_detector.pywith 33 tests coveringPatternDetectorandPatternPattern.to_dict— key completeness, isoformat datetime, optional fields default to None_calculate_average_error_rate/_calculate_tool_failure_rate— empty, zero, and mixed inputsdetect_error_rate_trends— no-pattern, warning, critical, zero-baseline edge casesdetect_tool_failure_frequency— no-pattern, warning, critical severity escalationdetect_new_failure_modes— 2× and 3× thresholds, zero-error baselinedetect_confidence_drops— below threshold, warning, critical, improvementdetect_all_patterns— empty input, grouping by agent, critical-before-warning sort order, baseline minimum enforcementTest plan
python3 -m pytest -q tests/test_pattern_detector.py→ 33 passedruff check tests/test_pattern_detector.py→ all checks passed🤖 Generated with Claude Code