Avoid memory exhaustion during data migration#1630
Merged
keshav-space merged 2 commits intomainfrom Oct 29, 2024
Merged
Conversation
- Avoid loading all records at once in memory Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Contributor
|
@keshav-space thanks for this, can we use our own paginate here? |
Member
Author
@TG1999 We cannot use vulnerablecode/vulnerabilities/models.py Lines 874 to 972 in 289f4b8 Also, afaik custom querysets are not directly available in data migrations. In this case it would be better to use the built-in queryset |
Member
Author
|
Merging this now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are nearly 15 million package vulnerability relationships in VCIO, and loading them all at once during data migration consumes all the memory.