Add a basic model for Known Exploited Vulnerabilities #1422
Merged
keshav-space merged 2 commits intoaboutcode-org:mainfrom Jul 15, 2024
Merged
Add a basic model for Known Exploited Vulnerabilities #1422keshav-space merged 2 commits intoaboutcode-org:mainfrom
keshav-space merged 2 commits intoaboutcode-org:mainfrom
Conversation
ziadhany
force-pushed
the
exploit-vul
branch
from
bf982a0 to
2cf5e72
Compare
Contributor
|
I think we need a new tab for this, @DennisClark what's your initial thoughts on this ? |
ziadhany
force-pushed
the
exploit-vul
branch
2 times, most recently
from
5d90bdc to
0a2d084
Compare
ziadhany
commented
Mar 12, 2024
|
|
||
| @property | ||
| def interesting_advisories(self) -> QuerySet: | ||
| return [Advisory.objects.all()[0]] |
Collaborator
Author
There was a problem hiding this comment.
I am not sure if this is the right way to just run the improver
keshav-space
requested changes
Jul 12, 2024
Member
keshav-space
left a comment
keshav-space
left a comment
There was a problem hiding this comment.
@ziadhany Thanks ++
Looking good! see minor nits for your consideration.
Also, please add some tests.
Add a Kev test & function docstrings Change the kev model ( known_ransomware_campaign_use from integer choices to boolean ) Add kev to api Access the vulnerability directly from Alias Add a tooltips and edit kev table Add a kev in a separate tab Solve migration conflict Add a basic improver squash migration files Add a basic Known Exploited Vulnerabilities model Signed-off-by: ziadhany <ziadhany2016@gmail.com>
keshav-space
approved these changes
Jul 15, 2024
Member
keshav-space
left a comment
keshav-space
left a comment
There was a problem hiding this comment.
Thanks @ziadhany, Merging!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1028