Remove llama_kv_cache_view and deprecations were deleted on llama.cpp side too#2030
Closed
serhii-nakon wants to merge 3 commits into
Closed
Remove llama_kv_cache_view and deprecations were deleted on llama.cpp side too#2030serhii-nakon wants to merge 3 commits into
serhii-nakon wants to merge 3 commits into
Conversation
serhii-nakon
force-pushed
the
remove_llama_kv_cache_view
branch
from
fe246ca to
15cc7e2
Compare
Author
|
By some reason even with this fixes it crashes - if it possible review it. Maybe it because of another fix in my local env (related with template strftime_now) |
Author
|
OK, I reverted back llama.cpp - it start works with fixes in this PR. Looks like here some more issues with new llama.cpp and llama-cpp-python compatibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rel: ggml-org/llama.cpp#13653
rel: #2026