Skip to content

Small bug fixes and upgrades related to Interstage (final update)#212

Merged
carlandreaslindstrom merged 3 commits into
mainfrom
bugfix__interstage_upgrade
Jun 6, 2026
Merged

Small bug fixes and upgrades related to Interstage (final update)#212
carlandreaslindstrom merged 3 commits into
mainfrom
bugfix__interstage_upgrade

Conversation

@carlandreaslindstrom

@carlandreaslindstrom carlandreaslindstrom commented May 19, 2026

Copy link
Copy Markdown
Collaborator

This PR is a final "cleanup" for the interstage work.

  • It contains a bug fix in the beam_physics utility, now dividing instead of multiplying by the factorial in higher-order dispersion calculations (the second-order dispersion is used a lot and was off by a factor 4).
  • Visual improvements to the interstage optics and layout plots, including adding drivers.
  • Some additional control parameters of density plots in Beam.
  • Added parallel loading of data in Runnable (used in interstage paper figures).
  • Renamed the isr_on_ref_part parameter in the ImpactX interstage (to be more self-consistent).
  • Removed the ISR kick mitigation offsets (not handled by adding ISR directly to the reference particle).
  • Fixed bug in the ImpactX interstage where the second lens was overwritten by the first.

…beam_physics higher order dispersions. Removed ISR kick mitigation offsets in Interstage.
@carlandreaslindstrom carlandreaslindstrom removed the request for review from ben-c-2013 June 6, 2026 08:35
@carlandreaslindstrom

Copy link
Copy Markdown
Collaborator Author

I will just merge these now that the tests are passed (they didn't before, so some bugs were fixed).

@carlandreaslindstrom carlandreaslindstrom merged commit b130741 into main Jun 6, 2026
2 checks passed
@carlandreaslindstrom carlandreaslindstrom deleted the bugfix__interstage_upgrade branch June 6, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant