Option for aligning the beam axis of generated beam to its propgation direction at Source #165
Merged
Merged
Conversation
…efined by pointing angles.
…n_beam_axis to align the generated beam's axis to its propagation direction.
…e beam, as this is done by Source. Also added checks for the drive beam being correctly aligned.
…ys set driver_source.align_beam_axis to True.
…ys set driver_source.align_beam_axis to True.
…river_source.align_beam_axis to True.
…river_source.align_beam_axis to True.
Collaborator
|
PR looks fine, but I'm worried about if particle time of arrival to point in The normal convention in tracking codes is that the particles are pushed between |
Collaborator
|
Reccomend to add issue to discuss the convention and its application, but merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified
Source.track()in order to align the beam axis of the generated beam to its propagation direction, as several of the stage subclasses do not allow tilted drive beams with a propagation direction not aligned to the beam axis ("crab beams").Also needed to modify several other files in order to make everything consistent.