Skip to content

chore: upgrade idsec-sdk-golang v0.1.14 -> v0.2.3#44

Merged
aaearon merged 2 commits intomainfrom
chore/upgrade-idsec-sdk-v0.2.3
Apr 21, 2026
Merged

chore: upgrade idsec-sdk-golang v0.1.14 -> v0.2.3#44
aaearon merged 2 commits intomainfrom
chore/upgrade-idsec-sdk-v0.2.3

Conversation

@aaearon
Copy link
Copy Markdown
Owner

@aaearon aaearon commented Apr 21, 2026

Summary

  • Upgrades github.com/cyberark/idsec-sdk-golang from v0.1.14 to v0.2.3
  • isp.FromISPAuth added a required retry-strategy parameter; passing nil preserves v0.1.14 behavior (which itself defaulted to nil internally via FromISPAuthWithRetry)
  • No new direct module dependencies; indirect dep set shrinks (gopsutil and friends removed)

Test plan

  • Unit tests pass (make test)
  • Integration tests pass (make test-integration)
  • Lint clean (make lint)
  • Live grant list round-trip against real SCA API verified on v0.2.3 binary

FromISPAuth gained a retry-strategy parameter; pass nil to preserve
v0.1.14 behavior (which itself defaulted to nil internally via
FromISPAuthWithRetry). No new direct module dependencies; indirect set
shrinks (gopsutil and friends dropped).

Verified: unit tests, integration tests, golangci-lint, and a live
`grant list` round-trip against the real SCA API.
Copilot AI review requested due to automatic review settings April 21, 2026 06:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the CyberArk idsec-sdk-golang dependency and applies the minimal code changes needed to accommodate the updated isp.FromISPAuth API, keeping runtime behavior consistent with the prior SDK version.

Changes:

  • Bump github.com/cyberark/idsec-sdk-golang from v0.1.14 to v0.2.3.
  • Update ISP client construction to pass the newly-required retry-strategy argument (nil to preserve prior behavior).
  • Refresh Go module metadata (go.mod / go.sum) to reflect the new dependency graph (fewer indirect deps).

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/workflows/service.go Updates isp.FromISPAuth call signature for the new SDK version.
internal/sca/service.go Updates isp.FromISPAuth call signature for the new SDK version.
go.mod Bumps the direct idsec-sdk-golang version and prunes indirect requirements.
go.sum Updates checksums for the new module graph (including removed indirect deps).
CHANGELOG.md Documents the SDK upgrade and the retry-strategy parameter behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/workflows/service.go Outdated
svc.ispAuth = ispAuth

client, err := isp.FromISPAuth(ispAuth, "uar", ".", "", svc.refreshAuth)
client, err := isp.FromISPAuth(ispAuth, "uar", ".", "", svc.refreshAuth, nil)
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing a bare nil for the new retry-strategy parameter makes the intent non-obvious and relies on readers knowing the SDK’s default behavior. Consider adding a short inline comment (or a named variable like retryStrategy := (*isp.RetryStrategy)(nil) / var retryStrategy isp.RetryStrategy = nil, depending on the SDK type) to document that nil is intentional to preserve previous behavior.

Suggested change
client, err := isp.FromISPAuth(ispAuth, "uar", ".", "", svc.refreshAuth, nil)
var retryStrategy isp.RetryStrategy = nil // Intentionally nil to preserve the SDK's default retry behavior.
client, err := isp.FromISPAuth(ispAuth, "uar", ".", "", svc.refreshAuth, retryStrategy)

Copilot uses AI. Check for mistakes.
Comment thread internal/sca/service.go Outdated

// Create ISP client
client, err := isp.FromISPAuth(ispAuth, "sca", ".", "", svc.refreshAuth)
client, err := isp.FromISPAuth(ispAuth, "sca", ".", "", svc.refreshAuth, nil)
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in workflows: the new retry-strategy argument is passed as a bare nil, which obscures why retries are disabled/defaulted. Please add an inline comment or a named variable to document that nil is intentionally used to preserve the pre-upgrade behavior.

Suggested change
client, err := isp.FromISPAuth(ispAuth, "sca", ".", "", svc.refreshAuth, nil)
retryStrategy := nil // Intentionally use no custom retry strategy to preserve pre-upgrade behavior.
client, err := isp.FromISPAuth(ispAuth, "sca", ".", "", svc.refreshAuth, retryStrategy)

Copilot uses AI. Check for mistakes.
@aaearon aaearon merged commit 400b691 into main Apr 21, 2026
1 check passed
@aaearon aaearon deleted the chore/upgrade-idsec-sdk-v0.2.3 branch April 21, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants