fixed memory use after free in vec_getattr and vec_setattr (#181)#192
Merged
Zuzu-Typ merged 5 commits intoZuzu-Typ:masterfrom Jan 8, 2023
Merged
fixed memory use after free in vec_getattr and vec_setattr (#181)#192Zuzu-Typ merged 5 commits intoZuzu-Typ:masterfrom
Zuzu-Typ merged 5 commits intoZuzu-Typ:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small patch to fix issue #181 :)
I just expanded macro
PyGLM_String_AsStringwhere it was used, and released the temporarybytesobject after all checks are done.It works fine on my side (linux x86_64, python 3.8) and fixes the issue