chore(core/vm): delete assembler/disassembler #31211

[gzliudan]

Proposed changes

Ref: ethereum#31211

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4661b40d-c519-4417-b34b-8f83ed73c764

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Removes the EVM assembler/disassembler components and updates the evm CLI and state-test utilities accordingly, aligning tooling around direct bytecode execution and enhanced state-test running/benchmarking.

Changes:

• Deleted core/asm (assembler/compiler + instruction iterator) and removed evm CLI compile/disasm commands that depended on it.
• Extended state test execution to optionally return gas used (StateTest.RunWithGas) and updated the evm statetest runner to use it (including filtering/bench support).
• Refactored evm CLI flags and reporting: unified tracing flag handling, added a reporter and EEST metadata parsing helper.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/state_test_util.go	Adds RunWithGas to return gas usage alongside post-state; Run delegates to it.
core/vm/runtime/runtime_test.go	Removes core/asm usage from a skipped documentation helper.
core/asm/lexer.go	Deleted: assembler lexer implementation.
core/asm/lex_test.go	Deleted: lexer tests.
core/asm/compiler.go	Deleted: assembler compiler implementation.
core/asm/asm_test.go	Deleted: instruction iterator tests.
core/asm/asm.go	Deleted: instruction iterator + disassembly helpers.
cmd/evm/staterunner.go	Adds fork/index filtering, stdin batch mode, benchmarking integration, and uses RunWithGas.
cmd/evm/runner.go	Removes EASM compilation path; adds benchmarking/stats collection and prestate/trie setup changes.
cmd/evm/main.go	Removes compile/disasm commands, refactors flags (trace-focused), adds helpers for tracing, file collection, and state dumping.
cmd/evm/reporter.go	New: human/JSON reporting for state-test results.
cmd/evm/eest.go	New: parsing helper for EEST-encoded test metadata in names.
cmd/evm/internal/compiler/compiler.go	Deleted: wrapper around core/asm compiler.
cmd/evm/disasm.go	Deleted: evm disasm command.
cmd/evm/compiler.go	Deleted: evm compile command.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.