no_entrypoint_imports#985
Conversation
btr-rmconsole-5
Bot
added
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
greglittlefield-wf
left a comment
greglittlefield-wf
left a comment
There was a problem hiding this comment.
Just a couple small comments, otherwise LGTM!
| // ignore: unused_shown_name | ||
| import 'package:over_react/over_react.dart' | ||
| show PropDescriptor, PropsMeta; | ||
| import 'package:over_react/over_react.dart' show PropDescriptor, PropsMeta; |
There was a problem hiding this comment.
Should this be updated to a src import?
There was a problem hiding this comment.
ohh good catch :loading:
| import 'package:over_react/src/util/css_value_util.dart'; | ||
| import 'package:platform_detect/platform_detect.dart'; | ||
|
|
||
| import '../../react_dom.dart' as react_dom; |
There was a problem hiding this comment.
Could we make this a package: import instead of a relative path?
There was a problem hiding this comment.
should I move the react_dom.dart file into src and re-export it from lib?
There was a problem hiding this comment.
because that file is lib/react_dom.dart so I couldn't get a src import
There was a problem hiding this comment.
Ohh is this the same file as package:over_react/react_dom.dart? Yeah, if you wouldn't mind, I think that'd be better
| ReactElement; | ||
| import 'package:w_common/disposable.dart'; | ||
|
|
||
| import '../../../react_dom.dart' as react_dom; |
There was a problem hiding this comment.
Same comment as above
btr-rmconsole-7
Bot
added
Merge Requirements Unmet
and removed
Merge Requirements Met
labels
btr-rmconsole-4
Bot
added
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
|
@Workiva/release-management-p |
5 participants
Problem
An entrypoint import can be defined as an import within
lib/srcthat imports a file withinlib/*.dart(the entrypoints of a dart package). These imports are always unnecessary, and can contribute to slower dart build performance.Solution
This PR naively removes every entrypoint import within the repo, and updates the
gha-dart/.../checks.yamlto the latest version. In order to merge this PR a few manual changes must be performed:no_entrypoint_importsadditional-checks option ingha-dart@v2.10.13that was added in this PR. This will prevent new entrypoint imports from getting added once this PR mergesOur request to teams is to perform the above tasks, so we can default enable the
no_entrypoint_importscheck for all gha-dart consumers. Please reach out to #support-frontend-dx for any questions or issuesQA
Created by Sourcegraph batch change
Workiva/no_entrypoint_imports.