FED-3274 React 18 Prep#973
Merged
Merged
Conversation
sydneyjodon-wk
commented
Jan 31, 2025
aaronlademann-wf
previously approved these changes
Feb 4, 2025
aaronlademann-wf
left a comment
Contributor
There was a problem hiding this comment.
Couple of questions, but otherwise LGTM
aaronlademann-wf
previously approved these changes
Feb 4, 2025
greglittlefield-wf
requested changes
Feb 4, 2025
greglittlefield-wf
left a comment
Contributor
There was a problem hiding this comment.
Just one small comment; thanks for fixing that analyzer plugin issue!
Co-authored-by: Greg Littlefield <greg.littlefield@workiva.com>
greglittlefield-wf
approved these changes
Feb 4, 2025
greglittlefield-wf
left a comment
Contributor
There was a problem hiding this comment.
- Changes look good
- CI passes with React 18 pulled in
- Assuming CI passes again on this PR on the latest commit
+10
aaronlademann-wf
approved these changes
Feb 4, 2025
Contributor
Author
|
@Workiva/release-management-p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A couple test updates in order to get tests passing on React 18
Changes
react_dom.renderto avoid RTL error about usingactin prod buildsRelease Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: