FED-3255 Allow analyzer 6.x

[greglittlefield-wf]

Depends on #958

Motivation

over_react currently allows analyzer 5.x, but not analyzer 6.x, which prevents newer versions of other packages from being pulled in.

We were previously blocked on supporting analyzer 6.x since it can only be used in Dart 3, but now we support Dart 3!

Changes

• Raise analyzer upper bound to allow 6.x
• Add 6.x to CI matrix that validates behavior under different analyzer majors
• Fix usages of deprecated NamedType.name, which was removed in analyzer 6.0.0
  • This getter included the name and any import prefix, and was deprecated in favor of the following getters:
    • name2 (the name without the prefix)
    • importPrefix (just the prefix)

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

• Tests were updated and provide good coverage of the changeset and other affected code
• Manual testing was performed if needed
  • Steps from PR author:
    • CI passes
  • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

• A Frontend Frameworks Design member has reviewed these changes
• There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
• For release PRs - Version metadata in Rosie comment is correct

[aviary2-wf]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[greglittlefield-wf]

This extension is exclusive to Identifier, and in analyzer 6 type names are no longer parsed as Identifier, so these cases needed to be updated

[robbecker-wf]

🎊

The base branch was changed.

[robbecker-wf]

QA+1 CI passes on all combinations. Validated that analyzer 5 and 6 are actually used and pass.

[greglittlefield-wf]

@Workiva/release-management-p

[rmconsole-wf]

+1 from RM