Skip to content

FED-3249 Update docs about migrator companion codemod#959

Merged
rmconsole2-wf merged 3 commits into
masterfrom
update-note-about-migrator-companion
Oct 24, 2024
Merged

FED-3249 Update docs about migrator companion codemod#959
rmconsole2-wf merged 3 commits into
masterfrom
update-note-about-migrator-companion

Conversation

@sydneyjodon-wk

@sydneyjodon-wk sydneyjodon-wk commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

Motivation

Update the docs on the migrator companion codemod to take into account the changes from the following codemods:

Changes

  • Update docs

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

Comment thread doc/null_safety/null_safe_migration.md
@aviary3-wk

Copy link
Copy Markdown

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@rmconsole3-wf rmconsole3-wf changed the title Update docs about migrator companion codemod FED-3249 Update docs about migrator companion codemod Oct 15, 2024
@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review October 23, 2024 18:02

@greglittlefield-wf greglittlefield-wf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor comments

Comment thread doc/null_safety/null_safe_migration.md
Comment thread doc/null_safety/null_safe_migration.md Outdated

@greglittlefield-wf greglittlefield-wf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes look good
  • All links work in rendered markdown

+10

@Workiva/release-management-p

@rmconsole-wf rmconsole-wf left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole2-wf rmconsole2-wf merged commit d880fa1 into master Oct 24, 2024
@rmconsole2-wf rmconsole2-wf deleted the update-note-about-migrator-companion branch October 24, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants