Add missing argument in Pool.create_or_update_pool#2876
Merged
dhruvkb merged 1 commit intoAug 29, 2023
Merged
Conversation
obulat
approved these changes
Aug 24, 2023
obulat
left a comment
Contributor
There was a problem hiding this comment.
Since this param does not exist in the previous airflow versions, adding it in a PR to the dependabot PR seems correct.
AetherUnbound
approved these changes
Aug 29, 2023
AetherUnbound
left a comment
Collaborator
There was a problem hiding this comment.
The changes look good, I was able to confirm tests look good locally after building!
cb352f2
into
dependabot/pip/catalog/apache-airflow-amazonhttppostgres--2.7.0
stacimc
pushed a commit
that referenced
this pull request
Aug 29, 2023
…alog (#2869) * Bump apache-airflow[amazon,http,postgres] in /catalog Bumps [apache-airflow[amazon,http,postgres]](https://github.com/apache/airflow) from 2.6.3 to 2.7.0. - [Release notes](https://github.com/apache/airflow/releases) - [Changelog](https://github.com/apache/airflow/blob/main/RELEASE_NOTES.rst) - [Commits](apache/airflow@2.6.3...2.7.0) --- updated-dependencies: - dependency-name: apache-airflow[amazon,http,postgres] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Add missing argument in `Pool.create_or_update_pool` (#2876) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dhruv Bhanushali <hi@dhruvkb.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes CI failure on Dependabot PR #2869
Description
This is a separate PR and not committed directly to the Dependabot PR #2869 because I don't really know if this is the right fix. Note that the value is set to
Falsebecause that is the default.Testing Instructions
As this PR aims to fix CI failures, CI should pass.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin