CI: Do not run build-plugin-zip when PR metadata changes#841
CI: Do not run build-plugin-zip when PR metadata changes#841yogeshbhutkar wants to merge 1 commit into
build-plugin-zip when PR metadata changes#841Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #841 +/- ##
==========================================
Coverage 75.50% 75.50%
Complexity 2086 2086
==========================================
Files 99 99
Lines 8626 8626
==========================================
Hits 6513 6513
Misses 2113 2113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
build-plugin-zip on edited PR Typebuild-plugin-zip when PR metadata changes
dkotter
left a comment
There was a problem hiding this comment.
I'm open to thoughts here but this workflow is intentionally run on the edited flow as the purpose of this workflow is to build a final plugin zip which then triggers our PR Playground Preview workflow.
That workflow will add a link to the PR description that will open that PR in a Playground instance. That workflow uses the WordPress Playground PR Preview Action and it recommends using the edited action. The main reason for that is if someone edits the PR and removes the Playground link, the workflow will automatically trigger and add it back.
|
This makes sense to me. Thank you for your time. Closing this PR as this is a calculated decision. |
What, Why, and How?
While working on other PRs, I noticed that build-plugin-zip reruns for PR metadata-only changes, such as title or description edits. Each run takes about three minutes, and since the generated artifact depends on the PR code rather than PR metadata, repeated edits can waste CI time. This change limits the workflow to code-relevant PR events (opened, synchronize, and reopened), matching Gutenberg’s corresponding workflow, which uses the default pull_request activity types.
P.S. edited also runs when the PR base branch changes. If we decide that base-branch changes should still rebuild the plugin ZIP (which I don't think is required), we can keep edited and add an if guard so only that specific edit path triggers the workflow.
Use of AI Tools
AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5.5
Used for: Code review
Testing Instructions
build-plugin-zip.Changelog Entry