Update bundled wp deps (theme, ui, dataviews, admin-ui)#789
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #789 +/- ##
==========================================
Coverage 76.50% 76.50%
Complexity 1868 1868
==========================================
Files 89 89
Lines 7985 7985
==========================================
Hits 6109 6109
Misses 1876 1876
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
With WordPress/gutenberg#79594 in and GB |
|
@simison based on your last comment, is this PR ok to proceed with review/testing or should this be put on hold? |
|
Let's wait until Monday—Tuesday to see if we release new improved package versions which I'd rather update to. I can re-ping then. AI plugin is no longer breaking with Gutenberg trunk version since the revert in GB. |
I haven't tested this PR yet but note while it's a great goal to maintain compatibility with the latest version of Gutenberg, a more important goal is to maintain compatibility with our minimum WordPress version (7.0) that may not be running the Gutenberg plugin. As I said, haven't tested this PR yet so the dependency updates here may be fine but we need to be careful about not updating and using newer dependencies that don't exist yet on WordPress 7.0 |
What?
Updates some of the bundled WordPress packages for the AI settings route:
@wordpress/admin-ui2.4,@wordpress/dataviews17,@wordpress/ui0.16, and@wordpress/theme0.16.Also adapts to breaking API changes:
Popover.Popupplacement props moved toPopover.Positioner, and--wpds-color-fg-*tokens renamed to--wpds-color-foreground-*.Why?
The AI settings page crashed when the Gutenberg plugin
trunkor latest RC2 version was active (Cannot unlock an undefined object).Latest stable GB v23.4.0 works fine.
Bundled
@wordpress/ui0.12 relied onunlock(theme.privateApis), but Gutenberg’swp.themeno longer exportsprivateApis(theme 0.16 madeThemeProviderpublic). Aligning these bundled deps with the current Gutenberg release fixes that mismatch and keeps DataForm/UI components compatible with the runtime WordPress provides.I tested with the latest stable WP without Gutenberg, and this seemed to work as well.
Note that we might also add back lock/unlock to theme for backwards compatibility (WordPress/gutenberg#79594), but for now, anyway, it's a good idea to update.
How?
Update deps.
Use of AI Tools
yes
Testing Instructions
Smoke test settings route built with
wp-buildScreenshots or screencast
Changelog Entry