Skip to content

Update bundled wp deps (theme, ui, dataviews, admin-ui)#789

Open
simison wants to merge 1 commit into
WordPress:developfrom
simison:update/wp-ui
Open

Update bundled wp deps (theme, ui, dataviews, admin-ui)#789
simison wants to merge 1 commit into
WordPress:developfrom
simison:update/wp-ui

Conversation

@simison

@simison simison commented Jun 26, 2026

Copy link
Copy Markdown
Member

What?

Updates some of the bundled WordPress packages for the AI settings route: @wordpress/admin-ui 2.4, @wordpress/dataviews 17, @wordpress/ui 0.16, and @wordpress/theme 0.16.

Also adapts to breaking API changes: Popover.Popup placement props moved to Popover.Positioner, and --wpds-color-fg-* tokens renamed to --wpds-color-foreground-*.

Why?

The AI settings page crashed when the Gutenberg plugin trunk or latest RC2 version was active (Cannot unlock an undefined object).

Latest stable GB v23.4.0 works fine.

Bundled @wordpress/ui 0.12 relied on unlock(theme.privateApis), but Gutenberg’s wp.theme no longer exports privateApis (theme 0.16 made ThemeProvider public). Aligning these bundled deps with the current Gutenberg release fixes that mismatch and keeps DataForm/UI components compatible with the runtime WordPress provides.

I tested with the latest stable WP without Gutenberg, and this seemed to work as well.

Note that we might also add back lock/unlock to theme for backwards compatibility (WordPress/gutenberg#79594), but for now, anyway, it's a good idea to update.

How?

Update deps.

Use of AI Tools

yes

Testing Instructions

Smoke test settings route built with wp-build

Screenshots or screencast

Before After

Changelog Entry

Added - New feature.
Changed - Existing functionality.
Deprecated - Soon-to-be removed feature.
Removed - Feature.
Fixed - Bug fix.
Security - Vulnerability.
Developer - Development related updates.

Open WordPress Playground Preview

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: simison <simison@git.wordpress.org>
Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>
Co-authored-by: dkotter <dkotter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.50%. Comparing base (dd3420e) to head (b004692).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #789   +/-   ##
==========================================
  Coverage      76.50%   76.50%           
  Complexity      1868     1868           
==========================================
  Files             89       89           
  Lines           7985     7985           
==========================================
  Hits            6109     6109           
  Misses          1876     1876           
Flag Coverage Δ
unit 76.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@simison

simison commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

With WordPress/gutenberg#79594 in and GB trunk stable, it might make sense to wait a bit until we figure out a way to re-implement theme package release.

@jeffpaul

Copy link
Copy Markdown
Member

@simison based on your last comment, is this PR ok to proceed with review/testing or should this be put on hold?

@jeffpaul jeffpaul added this to the 1.1.0 milestone Jun 26, 2026
@jeffpaul jeffpaul moved this from Triage to In progress in WordPress AI Roadmap Jun 26, 2026
@simison

simison commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

Let's wait until Monday—Tuesday to see if we release new improved package versions which I'd rather update to. I can re-ping then.

AI plugin is no longer breaking with Gutenberg trunk version since the revert in GB.

@dkotter

dkotter commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

AI plugin is no longer breaking with Gutenberg trunk version since the revert in GB.

I haven't tested this PR yet but note while it's a great goal to maintain compatibility with the latest version of Gutenberg, a more important goal is to maintain compatibility with our minimum WordPress version (7.0) that may not be running the Gutenberg plugin.

As I said, haven't tested this PR yet so the dependency updates here may be fine but we need to be careful about not updating and using newer dependencies that don't exist yet on WordPress 7.0

@jeffpaul jeffpaul modified the milestones: 1.1.0, 1.2.0 Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

3 participants