refactor: remove unused put_raw, put_overwrite, get_raw storage APIs

[grumbach]

Removes put_raw(), put_overwrite(), and get_raw() from LmdbStorage. These bypass BLAKE3 content-address verification and have no callers outside their own tests. -270 lines, 4 tests removed.

[greptile-apps]

Greptile Summary

This PR removes three LmdbStorage methods — put_raw, put_overwrite, and get_raw — that bypassed BLAKE3 content-address verification, along with all four of their dedicated tests (~270 lines). A codebase-wide search confirms none of these methods had any callers outside their own test block, making the removal safe and the resulting API entirely content-verified.

• put_raw / put_overwrite / get_raw deleted — all bypassed BLAKE3 address verification, which is a security invariant of the storage layer per the project's design.
• 4 tests (test_put_raw_and_get_raw, test_get_raw_not_found, test_put_overwrite_new_record, test_put_overwrite_updates_stats_correctly) removed alongside the dead methods.
• Remaining public API (put, get, exists, delete, stats, current_chunks) is fully content-verified and its test coverage is preserved.
• No compilation or correctness issues found in the retained code.

Confidence Score: 5/5

• Safe to merge — removes dead code with no callers; no logic or API contract changes to the retained path.
• The change is purely subtractive: three unverified storage helpers and their tests are deleted. A grep across the full repository finds zero remaining references to put_raw, put_overwrite, or get_raw. The retained code compiles cleanly, all existing tests cover the verified API, and no production invariants are affected.
• No files require special attention.

Important Files Changed

Filename	Overview
src/storage/lmdb.rs	Removes put_raw, put_overwrite, and get_raw (bypassed BLAKE3 verification) along with their 4 tests; no callers remain in the codebase, and the verified put/get API is untouched.

Sequence Diagram

sequenceDiagram
    participant Caller
    participant LmdbStorage
    participant BLAKE3
    participant LMDB

    Note over LmdbStorage: Retained verified API only

    Caller->>LmdbStorage: put(address, content)
    LmdbStorage->>BLAKE3: compute_address(content)
    BLAKE3-->>LmdbStorage: computed_address
    alt address mismatch
        LmdbStorage-->>Caller: Err(ContentAddressMismatch)
    else address matches
        LmdbStorage->>LMDB: write_txn → put(key, value) → commit
        LMDB-->>LmdbStorage: Ok
        LmdbStorage-->>Caller: Ok(was_new)
    end

    Caller->>LmdbStorage: get(address)
    LmdbStorage->>LMDB: read_txn → get(key)
    LMDB-->>LmdbStorage: Option(bytes)
    alt found & verify_on_read
        LmdbStorage->>BLAKE3: compute_address(bytes)
        BLAKE3-->>LmdbStorage: computed_address
        alt verification fails
            LmdbStorage-->>Caller: Err(VerificationFailed)
        else ok
            LmdbStorage-->>Caller: Ok(Some(bytes))
        end
    else not found
        LmdbStorage-->>Caller: Ok(None)
    end

Loading

_{Last reviewed commit: "refactor: remove unu..."}

[Copilot]

Pull request overview

Removes the raw/overwrite LMDB storage APIs that bypass BLAKE3 content-address verification, along with their dedicated tests, to keep LmdbStorage strictly content-addressed.

Changes:

• Removed put_raw(), put_overwrite(), and get_raw() from LmdbStorage.
• Removed tests that exclusively covered these raw/overwrite APIs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Removing put_raw/put_overwrite/get_raw changes the public API surface of LmdbStorage (which is re-exported from src/storage/mod.rs). If this crate follows semver for its library users, this should be treated as a breaking change (e.g., bump major version and/or document in changelog/release notes), or consider keeping stubs/deprecations for one release if downstream users might rely on these methods.

Suggested change

	/// Deprecated: use [`put`] instead.
	#[deprecated(note = "use `put` instead")]
	pub async fn put_raw(&self, address: &XorName, content: &[u8]) -> Result<bool> {
	self.put(address, content).await
	}
	/// Deprecated: use [`put`] instead and handle existing values explicitly.
	///
	/// This method retains the public API surface for backward compatibility.
	#[deprecated(note = "use `put` instead and handle existing values explicitly")]
	pub async fn put_overwrite(&self, address: &XorName, content: &[u8]) -> Result<()> {
	// Delegate to `put`; ignore whether the chunk already existed.
	let _ = self.put(address, content).await?;
	Ok(())
	}
	/// Deprecated: use [`get`] instead.
	#[deprecated(note = "use `get` instead")]
	pub async fn get_raw(&self, address: &XorName) -> Result<Option<Vec<u8>>> {
	self.get(address).await
	}