-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add structured JSON logging and file output support #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mickvandijke
merged 1 commit into
WithAutonomi:main
from
jacderida:feat-support_logging_for_auto_upgrade_tests
Mar 3, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,23 @@ | ||
| //! Build script for saorsa-node. | ||
|
|
||
| use std::process::Command; | ||
|
|
||
| fn main() { | ||
| // Rerun if feature configuration changes | ||
| // Rerun if the git HEAD pointer changes (branch switch, detached HEAD, etc.) | ||
| println!("cargo:rerun-if-changed=.git/HEAD"); | ||
| // Rerun if the current branch tip moves (new commits) | ||
| println!("cargo:rerun-if-changed=.git/refs/heads"); | ||
| // Rerun if refs are packed (e.g. after `git gc`) | ||
| println!("cargo:rerun-if-changed=.git/packed-refs"); | ||
| println!("cargo:rerun-if-changed=build.rs"); | ||
|
|
||
| let commit = Command::new("git") | ||
| .args(["rev-parse", "--short", "HEAD"]) | ||
| .output() | ||
| .ok() | ||
| .filter(|o| o.status.success()) | ||
| .and_then(|o| String::from_utf8(o.stdout).ok()) | ||
| .map_or_else(|| "unknown".to_string(), |s| s.trim().to_string()); | ||
|
|
||
| println!("cargo:rustc-env=SAORSA_GIT_COMMIT={commit}"); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stale commit hash on incremental builds
cargo:rerun-if-changed=.git/HEADonly tracks the HEAD pointer file (which typically containsref: refs/heads/main— a static string that does not change when new commits are made on the current branch). Cargo will therefore skip re-running the build script after agit commiton the same branch, meaning the embeddedSAORSA_GIT_COMMITvalue becomes stale until something else triggers a full rebuild.To keep the embedded hash up-to-date you need to also watch the ref that HEAD points to, as well as
packed-refs(which is updated when refs are packed):Alternatively, consider the
vergencrate which handles all of these edge cases automatically.Prompt To Fix With AI