Feat: Markdown kit for readme, changelog & code#1
Draft
WilcoSp wants to merge 25 commits intofeat/changelog-1from
Draft
Feat: Markdown kit for readme, changelog & code#1WilcoSp wants to merge 25 commits intofeat/changelog-1from
WilcoSp wants to merge 25 commits intofeat/changelog-1from
Conversation
…is in a heading then the link to the heading is always at the end now
Owner
Author
|
I'm done combining the code, for readme the tests are 100% with the only one being changed are for heading. I'm currently writing tests for changelog's markdown renderer for the things that are different compared to readme. |
…from h3 for changelog.md while it should've started at h2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr in specific is only to compare, it won't be merged!
🧭 Context
Currently changelog uses a seperate marked markdown renderer from readme, this pr takes the shared code and makes it into a "markdown kit" so that code that can be shared will be shared
📚 Description
moves shared code for both changelog & readme to a shared markdown kit while still allowing for each to have their unique needs.
Heading have been changed to be more consistent and easier to use by users to the following:
## heading-><hx><a href="#...>heading</a></hx>## [Example](https://example.com)-><hx><a href="https://example.com">Example</a><a href="#...></a></hx>