Closed
Conversation
Create new release version 1.2.1
Handle Bot Typing on Fulfillment Message
Fix Typing Indicator
Fix bot typing
Finally Fixing Typing Indicator
[Upstream Catchup] Merge RocketChat/Apps.Dialogflow:master to master
Update Apps-Engine
|
@AlexanderKanakis can you add something in the description field please as to what is in this PR? |
Collaborator
Author
|
@ear-dev Done! |
Shailesh351
reviewed
Jun 26, 2021
| await botTypingListener(rid, this.modify.getNotifier().typing({ id: rid, username: DialogflowBotUsername })); | ||
| response = (await Dialogflow.sendRequest(this.http, this.read, this.modify, this.persistence, rid, text, DialogflowRequestType.MESSAGE)); | ||
| await botTypingListener(this.modify, rid, DialogflowBotUsername); | ||
| response = (await Dialogflow.sendRequest(this.http, this.read, this.modify, rid, text, DialogflowRequestType.MESSAGE)); |
Collaborator
There was a problem hiding this comment.
4th argument this.persistence is missing here. Isn't it giving you an error?
Collaborator
Author
There was a problem hiding this comment.
@Shailesh351 you can ignore this PR, I will make the changes in a new one. Should I pull from cx_development or master?
Collaborator
There was a problem hiding this comment.
What about one PR for merging master in cx_development. And one for this mediaCardURL?
Collaborator
Author
There was a problem hiding this comment.
I want to do a small PR to fix Steve's issue from yesterday. I will just update this PR to be only about changes for mediaCardURL.
ear-dev
pushed a commit
that referenced
this pull request
Jan 24, 2022
Co-authored-by: murtaza98 <murtaza.patrawala@rocket.chat>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed custom payload object property "imageCardUrl" to "mediaCardUrl" to match the changes in RC's customFields handling.