Support New Welcome Event Custom Payload#71
Merged
chadgoss merged 1 commit intoWideChat:masterfrom Jul 8, 2021
Merged
Conversation
chadgoss
reviewed
Jun 30, 2021
chadgoss
reviewed
Jul 6, 2021
Collaborator
chadgoss
left a comment
chadgoss
left a comment
There was a problem hiding this comment.
@Shailesh351
how hard would it be for new_welcome_event to always create a new room (and DF session)?
fulfillment currently tracks all kinds of session state.. clearing it all up when we want to consider something new is a major headache..
Shailesh351
force-pushed
the
sb_new_welcome_event
branch
from
32deb80 to
73c30ed
Compare
ear-dev
pushed a commit
that referenced
this pull request
Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of WideChat/Rocket.Chat#795