Conversation
|
Thanks @AlexanderKanakis 2 small things please...
e |
|
Also..... is this a typo? Not sure it makes sense to have this labeled [CX ONLY] and to suggest that it's not for CX.... :-) Dialogflow CX does not use fallback events. This setting lists events that will be treated AS fallbacks by our Apps.Dialogflow. I can change the description and label to make this more clear. |
|
@AlexanderKanakis How does authentication work? thanks |
|
"Agent Version" at the top.... toggles between ES/CX
Thoughts? |
All of these settings are necessary for CX as well. There are only some CX exclusive. |
ES authenticates by sticking an access token as a URL parameter in its requests. CX authenticates by placing the access token in the request's header. |
|
How do we configure the authentication token in CX? For ES there is an input box, do we need something similar for CX? |
|
The authentication token in ES is configured with the private key and the client email. We get the authentication token in CX in the exact same way. EDIT: It occured to me that the ES and CX agent might not be part of the same service as it is in my case. I will add the same fields (project id, client email, private key) as an optional input for CX, just in case the two agents are not part of the same service. |
|
Ah, cool..... thanks. I think we can make some UI improvements here, and you probably saw the story I created about it. Let me know what you think. thanks. |
Lets discus at standup, but I dont think we want the RC DF app doing an conversation manipulation |
|
@Shailesh351 please review when you can....... thanks! |
Shailesh351
left a comment
There was a problem hiding this comment.
Functionally this PR Looks good to me. Nice work @AlexanderKanakis 🎉
I found that there are lint in some files. We have tslint configured in the project. You can use it for fixing lint issues.
Thanks!
lib/payloadAction.ts
Outdated
| await closeChat(modify, read, rid); | ||
| } | ||
| else if (actionName === ActionIds.SET_TIMEOUT) { | ||
| let n = setTimeout(async () => { |
There was a problem hiding this comment.
setInterval, setTimeout is not supported in The RC Apps currently. For reference RocketChat#30
They do have Schedular API https://developer.rocket.chat/apps-development/fundamentals-of-apps/scheduler-api
Issues resolved in new commit! |
|
Thanks @AlexanderKanakis @Shailesh351 ! |
Release version 1.2.1


Changes