More work towards a wasip3 target#636
Draft
alexcrichton wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
@TartanLlama building this PR, with this minor patch on wasi-libc, currently yields: This is with LLVM assertions enabled. I think this has to do with some features/etc related work on #200855, but I'm not exactly sure what. Would it be helpful to have a standalone reproducer? |
|
@alexcrichton it's cause you also need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress to get things enabled. The main bulk of the change here is updating LLVM itself to tip-of-tree as of yesterday morning. This removes two
*.patchfiles because they've landed, and adds another*.patchfile to work around a new issue that's cropped up. I've also included a*.patchfor llvm/llvm-project#200855, too.This isn't ready yet to land as it's still failing to build/link/etc, and I'll comment some more below.