More CI Fixes#119
Conversation
| # Need a more recent cmake than ships with stretch | ||
| RUN curl -sSfL \ | ||
| https://github.com/Kitware/CMake/releases/download/v3.17.0/cmake-3.17.0-Linux-x86_64.tar.gz \ | ||
| | tar xzf - |
There was a problem hiding this comment.
Is it the use of -B build/llvm the in the Makefile that doesn't work. Maybe we can find a fix for that instead of this extra download?
There was a problem hiding this comment.
Looks like that solution is to use the -S and -B together maybe:
cmake [<options>] -S <path-to-source> -B <path-to-build>
There was a problem hiding this comment.
Actually that didn't fix it for me..
There was a problem hiding this comment.
Yeah it looks like the -B flag was added in 3.13: https://cmake.org/cmake/help/v3.13/release/3.13.html
Strange the older version silently ignore it :)
Anyway I think it easy enough to avoid the -B flag rather then downloading custom cmake? What do you think?
There was a problem hiding this comment.
I'll convert the makefile to cd to the build directory rather than use -B. Its disappointing that cmake chose to deploy a new flag that old versions ignore, though :(
|
With this fix I have a build of wasi-sdk, unfortunately it is version 9.2ga2aa6e93c5b7 This problem is on me for not checking if the docker build had bitrotted before tagging the release. |
|
How about tagging 9.1 and abandon 9? |
|
10 also sounds fine if your prefer. Could we also then use the build artifact from github as the linux binary that gets uploaded? |
|
To use an artifact from github we have to tag the branch, and then we can't do the squash-and-merge or rebase-and-merge. So, we can change the repo rules for just releases maybe? |
pchickey
force-pushed
the
pch/docker_tweaks
branch
from
e46656f to
5246c2c
Compare
|
unfortunately I still had a typo in the deb script, hopefully this is the last tweak... |
|
Finally got the deb uploading, and I've QA'd it by running the lucet test suite against it. Gonna merge and tag wasi-sdk-10! |
This works around [this bug], which manifests as ``` error: could not remove 'setup' file: 'C:\Users\VssAdministrator\.cargo\bin/rustup-init.exe' info: caused by: Access is denied. (os error 5) ``` as suggested by [this comment]. [this bug]: https://github.com/microsoft/azure-pipelines-image-generation/issues/1224 [this comment]: WebAssembly/wasi-libc#118 (comment)
2 participants
The Dockerfile bitrotted because it isn't checked in CI.
Sam fixed the cmake version issue in #120. This PR adds a job to run
docker_build.sh(in addition to the regular nativeubuntu-latestbuild) in CI.It also re-enables Windows.
If successful, we'll merge this PR and tag the result as version
wasi-sdk-10. We'll leave a note onwasi-sdk-9that it has been superseded by this new release. And we'll use the artifacts from the CI for thecreate: tagtrigger as the release binaries.