Skip to content

Use -fno-strict-aliasing for emmalloc#424

Merged
abrown merged 1 commit into
WebAssembly:mainfrom
cuviper:emmalloc-aliasing
Jun 23, 2023
Merged

Use -fno-strict-aliasing for emmalloc#424
abrown merged 1 commit into
WebAssembly:mainfrom
cuviper:emmalloc-aliasing

Conversation

@cuviper

@cuviper cuviper commented Jun 23, 2023

Copy link
Copy Markdown
Contributor

emmalloc uses a lot of pointer type-punning, which is UB under strict aliasing.

Fixes #421.

@abrown abrown left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through all the discussion in #421 and this makes sense to me. Thanks for figuring this out!

@abrown abrown merged commit bd950eb into WebAssembly:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

memory fault in emmalloc prev_region

2 participants