Skip to content

feat: deprecate JRPC V1#385

Merged
chaitanyapotti merged 3 commits intomasterfrom
feat/deprecate-jrpc-v1
Mar 2, 2026
Merged

feat: deprecate JRPC V1#385
chaitanyapotti merged 3 commits intomasterfrom
feat/deprecate-jrpc-v1

Conversation

@lwin-kyaw
Copy link
Contributor

@lwin-kyaw lwin-kyaw commented Feb 27, 2026

Motivation and Context

Jira Link:

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

Note

Low Risk
Primarily adds @deprecated annotations and documentation with no runtime behavior changes; the only functional change is a TypeScript-level generic return type on propagateToMutableRequest, plus lockfile metadata churn.

Overview
Marks the JRPC V1 engine, middleware types, provider helpers, and postMessage stream utilities as deprecated, with JSDoc pointers to the preferred V2 equivalents (e.g. JRPCEngineV2, JRPCMiddlewareV2, createEngineStreamV2, providerFromEngineV2).

Updates propagateToMutableRequest in v2/compatibility-utils to support a generic return type (and adds tests for the new typing behavior), and includes lockfile-only cleanup removing peer: true metadata entries.

Written by Cursor Bugbot for commit 0b52e5e. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

* @returns The mutable cloned request.
*/
export function propagateToMutableRequest(req: Record<string, unknown>, context: MiddlewareContext): Record<string, unknown> {
export function propagateToMutableRequest<ReturnType = Record<string, unknown>>(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename ReturnType since it shadows ts generic

@chaitanyapotti chaitanyapotti merged commit dc38d2e into master Mar 2, 2026
4 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/deprecate-jrpc-v1 branch March 2, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants