Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
src/jrpc/v2/compatibility-utils.ts
Outdated
| * @returns The mutable cloned request. | ||
| */ | ||
| export function propagateToMutableRequest(req: Record<string, unknown>, context: MiddlewareContext): Record<string, unknown> { | ||
| export function propagateToMutableRequest<ReturnType = Record<string, unknown>>( |
Member
There was a problem hiding this comment.
rename ReturnType since it shadows ts generic
chaitanyapotti
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link:
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Note
Low Risk
Primarily adds
@deprecatedannotations and documentation with no runtime behavior changes; the only functional change is a TypeScript-level generic return type onpropagateToMutableRequest, plus lockfile metadata churn.Overview
Marks the JRPC V1 engine, middleware types, provider helpers, and postMessage stream utilities as deprecated, with JSDoc pointers to the preferred V2 equivalents (e.g.
JRPCEngineV2,JRPCMiddlewareV2,createEngineStreamV2,providerFromEngineV2).Updates
propagateToMutableRequestinv2/compatibility-utilsto support a generic return type (and adds tests for the new typing behavior), and includes lockfile-only cleanup removingpeer: truemetadata entries.Written by Cursor Bugbot for commit 0b52e5e. This will update automatically on new commits. Configure here.