Skip to content

fix: radio cell should fallback to text in aggregation row #4027#5064

Merged
fangsmile merged 1 commit into
VisActor:fix/radio-aggregation-row-4027from
Erica-cod:fix/radio-aggregation-row-4027
Mar 25, 2026
Merged

fix: radio cell should fallback to text in aggregation row #4027#5064
fangsmile merged 1 commit into
VisActor:fix/radio-aggregation-row-4027from
Erica-cod:fix/radio-aggregation-row-4027

Conversation

@Erica-cod
Copy link
Copy Markdown
Contributor

@Erica-cod Erica-cod commented Mar 21, 2026

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Site / documentation update
  • Demo update
  • Workflow
  • Chore
  • Release
  • Other (about what?)

🔗 Related issue link

close #4027

💡 Background and solution

When a table has aggregation rows and a column is configured with cellType: 'radio', the radio button incorrectly appears in the aggregation row. However, checkbox type cells correctly fall back to plain text cells in the same scenario.

Root cause: In packages/vtable/src/scenegraph/group-creater/cell-helper.ts, the checkbox branch checks isAggregation && isSeriesNumber to decide whether to render a text cell instead of a checkbox, but the radio branch was missing this conditional check.

Solution: Added the same isAggregation && isSeriesNumber guard to the radio branch in createCell(). When the cell is in an aggregation row and is a series number column, it now renders as a plain text cell using createTextCellGroup instead of createRadioCellGroup, consistent with the checkbox behavior.

📝 Changelog

Language Changelog
🇺🇸 English fix: radio cell should fallback to text cell in aggregation row, consistent with checkbox behavior
🇨🇳 Chinese 修复:合计行中单选框(radio)单元格应降级为文本单元格,与复选框(checkbox)行为保持一致

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@fangsmile fangsmile changed the base branch from develop to fix/radio-aggregation-row-4027 March 25, 2026 01:20
@fangsmile fangsmile merged commit 52e2d51 into VisActor:fix/radio-aggregation-row-4027 Mar 25, 2026
2 checks passed
@fangsmile fangsmile mentioned this pull request Mar 25, 2026
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants