fix: radio cell should fallback to text in aggregation row #4027#5064
Merged
fangsmile merged 1 commit intoMar 25, 2026
Conversation
52e2d51
into
VisActor:fix/radio-aggregation-row-4027
2 checks passed
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #4027
💡 Background and solution
When a table has aggregation rows and a column is configured with
cellType: 'radio', the radio button incorrectly appears in the aggregation row. However,checkboxtype cells correctly fall back to plain text cells in the same scenario.Root cause: In
packages/vtable/src/scenegraph/group-creater/cell-helper.ts, thecheckboxbranch checksisAggregation && isSeriesNumberto decide whether to render a text cell instead of a checkbox, but theradiobranch was missing this conditional check.Solution: Added the same
isAggregation && isSeriesNumberguard to theradiobranch increateCell(). When the cell is in an aggregation row and is a series number column, it now renders as a plain text cell usingcreateTextCellGroupinstead ofcreateRadioCellGroup, consistent with the checkbox behavior.📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough