Skip to content

fix: add key to custom nodes #3840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fangsmile merged 1 commit into from
May 8, 2025
Merged

fix: add key to custom nodes #3840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/vue-vtable/src/utils/customLayoutUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as VTable from '@visactor/vtable';
import { convertPropsToCamelCase, toCamelCase } from './stringUtils';
import { isFunction, isObject } from '@visactor/vutils';
import { isVNode } from 'vue';
import { cloneVNode, isVNode } from 'vue';

// 检查属性是否为事件
function isEventProp(key: string, props: any) {
Expand Down Expand Up @@ -46,9 +46,18 @@ export function createCustomLayout(children: any, isHeader?: boolean, args?: any
if (isObject(props?.vue)) {
// vue 自定义节点：无需继续循环子节点
const { element } = props.vue as any;
const targetVNode = element ?? subChildren.find(node => node?.type !== Symbol.for('v-cmt'));
let targetVNode = element ?? subChildren.find(node => node?.type !== Symbol.for('v-cmt'));
if (isVNode(targetVNode)) {
// node 标记 key 增加唯一项标记，避免重复渲染
targetVNode = !targetVNode.key
? cloneVNode(targetVNode, { key: `row_${args.row}_col_${args.col}` })
: targetVNode;
} else {
targetVNode = null;
}

Object.assign(child.props.vue, {
element: isVNode(targetVNode) ? targetVNode : null,
element: targetVNode,
// 不接入外部指定
container: isHeader ? args?.table?.headerDomContainer : args?.table?.bodyDomContainer
});
Expand Down
Loading