Skip to content

3766 bug row frozen occor error #3794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fangsmile merged 2 commits into from
Apr 27, 2025
Merged

3766 bug row frozen occor error #3794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b732add
fix: when records is blank updateColumns api occor error #3766
fangsmile Apr 23, 2025
37e5a05
docs: update changlog of rush
fangsmile Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vtable/3766-bug-row-frozen-occor-error_2025-04-23-12-19.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: when records is blank updateColumns api occor error #3766\n\n",
"type": "none",
"packageName": "@visactor/vtable"
}
],
"packageName": "@visactor/vtable",
"email": "892739385@qq.com"
}
3 changes: 2 additions & 1 deletion packages/vtable/src/ListTable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ export class ListTable extends BaseTable implements ListTableAPI {
* Sets the define of the column.
*/
updateColumns(columns: ColumnsDefine) {
this.scenegraph.clearCells(); //将该代码提前 逻辑中有设置this.clear=true。refreshHeader逻辑中有判断clear这个值的地方
const oldHoverState = { col: this.stateManager.hover.cellPos.col, row: this.stateManager.hover.cellPos.row };
this.internalProps.columns = cloneDeepSpec(columns, ['children']);
generateAggregationForColumn(this);
Expand All @@ -230,7 +231,7 @@ export class ListTable extends BaseTable implements ListTableAPI {
this.dataSource.processRecords(this.dataSource.dataSourceObj?.records ?? this.dataSource.dataSourceObj);
}
this.internalProps.useOneRowHeightFillAll = false;
this.scenegraph.clearCells();

this.headerStyleCache = new Map();
this.bodyStyleCache = new Map();
this.bodyBottomStyleCache = new Map();
Expand Down
Loading