Skip to content

fix: fix row update range #3468 #3607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rui-Sun merged 1 commit into from
Mar 21, 2025
Merged

fix: fix row update range #3468 #3607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@visactor/vtable/fix-row-update-direction_2025-03-21-07-18.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@visactor/vtable",
"comment": "fix: fix row update range #3468",
"type": "none"
}
],
"packageName": "@visactor/vtable"
}
9 changes: 3 additions & 6 deletions packages/vtable/src/scenegraph/layout/update-row.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,12 +151,9 @@ export function updateRow(
const minRow = Math.min(...addRows);
scene.proxy.rowUpdatePos = Math.min(minRow, scene.proxy.rowUpdatePos);
}
// if (addRows.length > removeRows.length) {
scene.proxy.rowUpdateDirection = 'down';
// } else {
// scene.proxy.rowUpdateDirection = 'up';
// }
console.log('rowUpdateDirection', scene.proxy.rowUpdateDirection);
// 对于列表，折叠展开时最上行（按钮行行）位置不变，为基准向下更新，所以这里配置方向为up（从上向下更新）
// 对于透视表，最上行以上以下都也可能会变，目前采区重新建立场景树方案
scene.proxy.rowUpdateDirection = 'up';
scene.proxy.updateCellGroups(scene.proxy.screenRowCount * 2);
updateBottomFrozeCellGroups();
// scene.proxy.progress();
Expand Down