Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (4)
- Assets/Prefabs/UI/SettingsMenu/Menus/EphysLinkMenu.prefab: Language not supported
- Packages/manifest.json: Language not supported
- Packages/packages-lock.json: Language not supported
- ProjectSettings/ProjectSettings.asset: Language not supported
Comments suppressed due to low confidence (3)
Assets/Scripts/Pinpoint/UI/EphysLinkSettings/EphysLinkSettings.cs:119
- The condition for activating the pathfinder port input field changed from 'type == 2' to 'type == 1'. Please verify that this update correctly reflects the intended mapping of manipulator types.
_pathfinderPortInputField.gameObject.SetActive(type == 1);
Assets/Scripts/Pinpoint/UI/EphysLinkSettings/EphysLinkSettings.cs:228
- The simplified mapping for manipulator type string now only distinguishes between a value of 0 and non-0, removing previous cases like 'ump-3', 'new-scale', and 'ump-4'. Confirm that this change meets the intended functionality.
var manipulatorTypeString = _manipulatorTypeDropdown.value == 0 ? "ump" : "pathfinder-mpm";
Assets/Scripts/EphysLink/CommunicationManager.cs:25
- The minimum version constant has been updated from 2.0.0 to 2.1.0. Ensure that this change is consistent with version requirements across the codebase.
private static readonly int[] EPHYS_LINK_MIN_VERSION = { 2, 1, 0 };
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.