This repository was archived by the owner on Apr 30, 2025. It is now read-only.
Update composer.json#3
Closed
GrahamCampbell wants to merge 1 commit intoVectorface:masterfrom
GrahamCampbell:patch-1
Closed
Update composer.json#3GrahamCampbell wants to merge 1 commit intoVectorface:masterfrom GrahamCampbell:patch-1
GrahamCampbell wants to merge 1 commit intoVectorface:masterfrom
GrahamCampbell:patch-1
Conversation
Contributor
|
Thanks for the PR. This PR has pointed out a mistake on my part, the composer file should actually be using require-dev instead of require. Generally wildcard version constraints are a bad practice but in this case I believe I'm within the scope of using them in an acceptable way. If DUnit specifics a version constraint for PHPUnit it will have a conflict with any project that is using PHPUnit in require-dev that is outside of the ~4.0 version scope. DUnit should not restrict a PHPunit version because DUnit only calls the PHPUnit bin and doesn't care about the version of PHPUnit but instead that any version of PHPUnit exists. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wildcard version constraints are a bad practice.