Skip to content

Analysis refactoring#65

Merged
pmbittner merged 15 commits into
developfrom
benjamin/analysis-refactoring
Feb 28, 2023
Merged

Analysis refactoring#65
pmbittner merged 15 commits into
developfrom
benjamin/analysis-refactoring

Conversation

@ibbem
Copy link
Copy Markdown
Collaborator

@ibbem ibbem commented Feb 20, 2023

Refactoring of the analysis machinery. These changes where motivated by the changes in the thesis_lb branch and where originally discussed in #63. Note that there are some unrelated changes because of this.

@ibbem ibbem force-pushed the benjamin/analysis-refactoring branch from 0a3c948 to 8370477 Compare February 20, 2023 14:33
@ibbem ibbem mentioned this pull request Feb 20, 2023
@ibbem
Copy link
Copy Markdown
Collaborator Author

ibbem commented Feb 20, 2023

Note that 8370477 is an artifact of #63 where it was initially introduced by TheBormann.

@ibbem ibbem requested a review from pmbittner February 20, 2023 14:45
@pmbittner pmbittner added enhancement New feature or request Refactoring bm_work ibbem is paid for working on this labels Feb 21, 2023
This makes it easier to distinguish between hooks and the actual
analysis. The lost information, that this analysis is about commit
history, could be recovered by creating a new package for history
related analysis if necessary.
@ibbem ibbem force-pushed the benjamin/analysis-refactoring branch 3 times, most recently from 9d5eba2 to 03b48b7 Compare February 21, 2023 10:53
Copy link
Copy Markdown
Member

@pmbittner pmbittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment and afterwards we can merge.

Comment thread src/main/java/org/variantsync/diffdetective/metadata/Metadata.java
There are some behavioral changes:

- The
  > temporary fix for renaming from Unchanged to Untouched
  has been removed.

- There are two more metadata keys: `exportedCommits` and
  `exportedTrees`. These where previously called `processedCommits` and
  `processedTrees` and used with different meanings in the
  `DiffTreeMiner` and the validations which caused a bug increasing this
  these counters twice, although that was probably my mistake, introduced
  during refactoring or merging.

- The order of metadata snapshots has probably changed
@ibbem ibbem force-pushed the benjamin/analysis-refactoring branch from 03b48b7 to 7f124ac Compare February 22, 2023 19:02
@ibbem
Copy link
Copy Markdown
Collaborator Author

ibbem commented Feb 22, 2023

Added documentation for Metadata.mergeEqual, AnalysisResult.ResultKey, AnalysisResult.get and AnalysisResult.append.

@ibbem ibbem requested a review from pmbittner February 22, 2023 19:04
@pmbittner pmbittner merged commit d536a7f into develop Feb 28, 2023
@pmbittner pmbittner deleted the benjamin/analysis-refactoring branch March 14, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bm_work ibbem is paid for working on this enhancement New feature or request Refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants