Skip to content

fix open browser, execute shell command and logcat#405

Closed
koctuk999 wants to merge 3 commits intoVKCOM:developfrom
koctuk999:ksolow/fixShellCommand
Closed

fix open browser, execute shell command and logcat#405
koctuk999 wants to merge 3 commits intoVKCOM:developfrom
koctuk999:ksolow/fixShellCommand

Conversation

@koctuk999
Copy link
Copy Markdown

Fix websocket wire message construction for shell, browser, and logcat.

  • Fixed shell/browser payloads being serialized as objects, which caused [object Object] commands and URLs on providers.
  • Normalized Logcat filters before creating LogcatStartMessage, including treating default tag='*' as no server-side filter.
  • Maked transaction progress replies safe when no numeric progress value is provided, fixing shell output streaming crashes.

example of a failure before:

2025-12-16T13:39:22.288Z device INF/device:plugins:browser 23983 [*] Opening "http://[object Object]"
2025-12-16T13:39:58.733Z device INF/device:plugins:shell 23983 [*] Running shell command "[object Object]"

DroBov1Tya and others added 3 commits January 12, 2026 16:09
Without these arguments, the `processor` and `groups-engine` services crash on startup, causing devices to be invisible in the interface.
fix: add missing ZeroMQ endpoints to docker-compose (macos)
@koctuk999 koctuk999 requested a review from a team as a code owner April 14, 2026 11:45
@koctuk999
Copy link
Copy Markdown
Author

Problem with Logcat mentioned there: #403

@e-khalilov e-khalilov changed the base branch from master to develop April 14, 2026 12:09
@e-khalilov
Copy link
Copy Markdown
Collaborator

PRs can only be opened in the develop branch

@koctuk999
Copy link
Copy Markdown
Author

PRs can only be opened in the develop branch

Then you need to change the information in CONTRIBUTION.md

@koctuk999
Copy link
Copy Markdown
Author

I'm closing the current PR, because these changes are already in develop branch

@koctuk999 koctuk999 closed this Apr 14, 2026
@koctuk999
Copy link
Copy Markdown
Author

new pr #407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants