Closed
Conversation
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
…te changes Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
…og for a slew specific endpoint Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
…g manager Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
…state for values array per dashboard Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
…mponents Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Implement toggle mode Adjust size of the box for the WidgetPlayer Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
… mount to the nginx image Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branding can be applied by mounting a volume with data that looks much like the previous branding data.
Namely :
The folder containing all this data is now mounted to /usr/share/nginx/html/branding
A good template for it is the default branding in src/branding/default
The html files that reference images from img, have to reference their absolute path from the serving context (/branding/img/)
The build process then appends two tags to the index.html body, one of which is a script tag referencing the js that injects all that is needed at (almost) runtime.
Needless to say that the helm chart for the frontend needs to change accordingly, but this now allows to change the appearance of the website, after building it, by simply modfiying values.json ( or the html files ) and reloading the website.
PS: I am using XHR to request the files from the server as if they were local files. No sensitive data should go in any of the mounted files because they are directly accessible through a browser request. I would love to avoid this by aggreeing on a subset of elements to be modified by the branding, and limiting the mounted files to a single json file + images. The contents of the json file can then be interpolated to be the innerHTML of already known elements
PPS: Also meant to to be merged after the backlog of PR's to come