Skip to content

Feat/about use backend#35

Merged
anqilique merged 2 commits intomainfrom
feat/about-use-backend
May 2, 2026
Merged

Feat/about use backend#35
anqilique merged 2 commits intomainfrom
feat/about-use-backend

Conversation

@anqilique
Copy link
Copy Markdown
Contributor

Description

Get the "About Us" page to use the executives data from the backend instead of placeholder data.

Changes

  • Executives.tsx component fetches and uses the data from the API.
  • Deleted placeholders folder that contained only the now unused executives.json placeholder data.
  • Unimportant HTML-only change to About.tsx.

Extra Notes

  • Can eventually add a loader or nicer features depending on later design.
  • Executives are still using placeholder images.

@anqilique anqilique added the feature New feature being worked on label Apr 28, 2026
@anqilique anqilique marked this pull request as ready for review April 28, 2026 22:51
@anqilique anqilique requested a review from RLee64 April 28, 2026 22:51
Copy link
Copy Markdown
Collaborator

@RLee64 RLee64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just address the comment below and feel free to merge this in.

That said, this PR won't finish the current ticket. There's a bit more to do for the task since we'll want to hook up the other endpoints as well. Both Executives.tsx and ExecCard.tsx should have 2 modes, one for basic users and another for admins. The basic user view works exactly as implemented right now, but the admin view needs to expose functionality for editing/deleting (part of an individual ExecCard component) and creating (a separate component found in the main Executives file). I've attached an image below as an example.

For now just hardcode the user/admin modes (i.e. a const value at the top of the file), and we'll properly integrate it once user context is set-up.

Image

Comment thread client/src/components/Executives.tsx Outdated
@RLee64
Copy link
Copy Markdown
Collaborator

RLee64 commented Apr 29, 2026

Nice work! Just address the comment below and feel free to merge this in.

That said, this PR won't finish the current ticket. There's a bit more to do for the task since we'll want to hook up the other endpoints as well. Both Executives.tsx and ExecCard.tsx should have 2 modes, one for basic users and another for admins. The basic user view works exactly as implemented right now, but the admin view needs to expose functionality for editing/deleting (part of an individual ExecCard component) and creating (a separate component found in the main Executives file). I've attached an image below as an example.

Just adding onto this, #34 might be a good reference for stuff already done to differentiate between user and admin modes

@anqilique
Copy link
Copy Markdown
Contributor Author

Nice work! Just address the comment below and feel free to merge this in.

That said, this PR won't finish the current ticket. There's a bit more to do for the task since we'll want to hook up the other endpoints as well. Both Executives.tsx and ExecCard.tsx should have 2 modes, one for basic users and another for admins. The basic user view works exactly as implemented right now, but the admin view needs to...

I've addressed the comment about the loading message.

I'll likely not have time to start the rest of task until the end of next week, but I will look into it!

@anqilique anqilique merged commit 056f212 into main May 2, 2026
1 check passed
@anqilique anqilique deleted the feat/about-use-backend branch May 2, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature being worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants