Make fuzzer use static methods to create arbitrary objects#2440
Draft
IlyaMuravjov wants to merge 2 commits intomainfrom
Draft
Make fuzzer use static methods to create arbitrary objects#2440IlyaMuravjov wants to merge 2 commits intomainfrom
IlyaMuravjov wants to merge 2 commits intomainfrom
Conversation
Markoutte
reviewed
Jul 25, 2023
|
|
||
| private fun findAccessibleCreators(description: FuzzedDescription, classId: ClassId): Sequence<ExecutableId> = | ||
| (classId.allConstructors + (classId.jClass.methods | ||
| .filter { it.isStatic && it.returnType.id.isSubtypeOf(classId) } |
Collaborator
There was a problem hiding this comment.
Could you, please, check what will happen if generics are used? Something like:
class A<T> {
public static A<String> getStringTyped() { return new A<>("Test") }
private A(T value) {};
}
...
public void testedMethod(A<Integer> expected) { ... }
Collaborator
Author
There was a problem hiding this comment.
It will erroneously use getStringTyped() to create A<Integer>. I was assuming that java fuzzer doesn't attempt to fully respect generic types here, since similar issue could have been reproduced even before this pull request:
interface A<T> {
T get();
}
class AImpl implements A<String> {
@Override
public String get() {
return "Test";
}
}
...
public void testedMethod(A<Integer> expected) { ... }
Collaborator
There was a problem hiding this comment.
Fair enough, I tried to fix it with #2451. Please, review it when it is possible. I think same can be done for this PR when 2451 is merged.
6d93b45 to
400f616
Compare
Markoutte
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now fuzzer can use both static methods and constructors to create instances of arbitrary types.
Fixes #2437
How to test
Automated tests
Self-check list