Merged
Conversation
a582daa to
5728fb4
Compare
SBOne-Kenobi
approved these changes
Dec 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A new field has been introduced in SARIF reports:
locations.logialLocations. It is used to store the class name in which an error was detected.Example:
It helps to fix #1381 because errors from the one class may refer to another class.
Also this PR fixes #1383 by adding
org.utbot.sarif.SarifReport#getMethodDefinitionLineNumberfor methods without the last line number in the execution path:Fixes #1381, #1383
Type of Change
How Has This Been Tested?
Regression and integration tests
org.utbot.sarif.SarifReportTest
Manual Scenario
Please, repeat the scenario from the issues and check the result
Checklist: