Conversation
fixing ubuntu process start and log creating
Domonion
force-pushed
the
kononov-log-config-fix
branch
from
40fd4f1 to
4fd17d4
Compare
dtim
approved these changes
Oct 10, 2022
Collaborator
dtim
left a comment
dtim
left a comment
There was a problem hiding this comment.
LGTM, and this PR fixes the issue.
| JdkInfoService.jdkInfoProvider.info.path.resolve("bin${File.separatorChar}${osSpecificJavaExecutable()}").toString() | ||
| val cp = (this.javaClass.classLoader as PluginClassLoader).classPath.baseUrls.joinToString( | ||
| separator = ";", | ||
| separator = if (isWindows) ";" else ":", |
Collaborator
There was a problem hiding this comment.
I understand that cp is a classpath string and not a filesystem path in the strict sense, but maybe File.pathSeparator could be used here? What do you think?
denis-fokin
pushed a commit
that referenced
this pull request
Oct 12, 2022
[utbot-rd] fixing ubuntu process start and log creating (cherry picked from commit c30841d)
AbdullinAM
pushed a commit
to AbdullinAM/UTBotJava
that referenced
this pull request
Oct 17, 2022
[utbot-rd] fixing ubuntu process start and log creating
AbdullinAM
pushed a commit
to AbdullinAM/UTBotJava
that referenced
this pull request
Oct 17, 2022
[utbot-rd] fixing ubuntu process start and log creating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing ubuntu process start and log creating
Fixes #1118
Type of Change