Clean up declarative dir and tab-completion#1903
Merged
dopplershift merged 7 commits intoUnidata:mainfrom Aug 6, 2021
Merged
Conversation
dir and tab-completion
dopplershift
requested changes
Jun 14, 2021
710ba10 to
f3b5281
Compare
Member
|
Can you also fix the message here to remove "string" while you're here? MetPy/src/metpy/plots/declarative.py Lines 691 to 692 in 3f08b77 |
a53900a to
b7ca6cc
Compare
Add MetPyHasTraits class with current goal of modifying `__dir__` attr from HasTraits.
b7ca6cc to
767e13a
Compare
a92ef73 to
b2d6886
Compare
dopplershift
approved these changes
Aug 6, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patches the
__dir__inheritance oftraitlets.HasTraitsso that our classes indeclarative.pyhide any inherited names as well as any_or__names for users of declarative classes hoping for more helpful tab completion. These can still be discovered with the underlying types if necessary. Results: