Skip to content

fix(tests): stabilize test_ignored_keywords across CI #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bingtagui404 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tests): stabilize test_ignored_keywords across CI #647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions ultraplot/tests/test_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,30 @@
# assert uplt.rc["image.cmap"] == uplt.rc["cmap.sequential"] == "_magma_copy_r"


@pytest.mark.skip(reason="This is failing on github but not locally")
def test_ignored_keywords():
"""
Test ignored keywords and functions.
"""
with warnings.catch_warnings(record=True) as record:
warnings.simplefilter("always")
fig, ax = uplt.subplots(
gridspec_kw={"left": 3},
subplot_kw={"proj": "cart"},
subplotpars={"left": 0.2},
)
# only capture ultraplot warnings not general mpl warnings, e.g. deprecation warnings
record = [r for r in record if "UltraPlotWarning" in str(r)]
assert len(record) == 3
# Filter to only UltraPlotWarning to avoid environment-specific noise
uplt_warnings = [r for r in record if issubclass(r.category, uplt.warnings.UltraPlotWarning)]
messages = [str(w.message) for w in uplt_warnings]
assert any("gridspec_kw" in m for m in messages), f"Expected gridspec_kw warning, got: {messages}"
assert any("subplot_kw" in m for m in messages), f"Expected subplot_kw warning, got: {messages}"
assert any("subplotpars" in m for m in messages), f"Expected subplotpars warning, got: {messages}"

with warnings.catch_warnings(record=True) as record:
warnings.simplefilter("always")
fig.subplots_adjust(left=0.2)
assert len(record) == 1
uplt_warnings = [r for r in record if issubclass(r.category, uplt.warnings.UltraPlotWarning)]
messages = [str(w.message) for w in uplt_warnings]
assert any("subplots_adjust" in m for m in messages), f"Expected subplots_adjust warning, got: {messages}"


@pytest.mark.mpl_image_compare
Expand Down