Support displaying clock without perl (for non-macOS)#282
Merged
Chemaclass merged 7 commits intomainfrom Jul 11, 2024
Merged
Conversation
Chemaclass
requested review from
JesusValeraDev,
antonio-gg-dev,
cmayo,
fabriziofs and
khru
Chemaclass
force-pushed
the
feat/support-clock-without-perl
branch
from
a7aa195 to
b3c2a0d
Compare
Chemaclass
force-pushed
the
feat/support-clock-without-perl
branch
from
b3c2a0d to
4d2dc08
Compare
Chemaclass
changed the title
fabriziofs
approved these changes
Jul 11, 2024
JesusValeraDev
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Here #279 (diff) we found a way to enable the exec time for all OS, however it's depending on
perl. It is very unluckily that it's not installed by default, but in case it wouldn't be installed it would be interesting to use the old logic usingdate- which is something that all OS should have with more probability thanperl.🔖 Changes
dateto get the time in caseperlis not installed✅ To-do list
CHANGELOG.mdto reflect the new feature or fix