Update README.md for adding fixes to avoid setup errors for Windows u…#483
Open
Srabasti wants to merge 3 commits intoTrusted-AI:mainfrom
Open
Update README.md for adding fixes to avoid setup errors for Windows u…#483Srabasti wants to merge 3 commits intoTrusted-AI:mainfrom
Srabasti wants to merge 3 commits intoTrusted-AI:mainfrom
Conversation
…sers Adding fixes to avoid setup errors for Windows users Trusted-AI#372 Signed-off-by: Srabasti Banerjee <srabasti_b@ymail.com>
yehee
reviewed
Sep 22, 2023
yehee
left a comment
yehee
left a comment
There was a problem hiding this comment.
Just swinging by to give initial pass on the commit, I'll leave project owners to review :)
README.md
Outdated
| pip install --editable '.[all]' | ||
| ``` | ||
|
|
||
| ###For Windows machine |
There was a problem hiding this comment.
Suggested change
| ###For Windows machine | |
| ### For Windows machine |
lindawangg
reviewed
Sep 22, 2023
README.md
Outdated
| pip install --editable '.[all]' | ||
| ``` | ||
|
|
||
| ###For Windows machine |
There was a problem hiding this comment.
nit: Since this is conda installation instructions, lets add this to the conda section: https://github.com/Trusted-AI/AIF360#conda
Co-authored-by: Gowri Addepalli <gauriaddepalli@gmail.com> Signed-off-by: Manish Nagireddy <65432909+mnagired@users.noreply.github.com>
Co-authored-by: Gowri Addepalli <gauriaddepalli@gmail.com> Co-authored-by: Alice <aliceykim0828@gmail.com> Signed-off-by: Manish Nagireddy <65432909+mnagired@users.noreply.github.com>
mnagired
approved these changes
Sep 27, 2023
Collaborator
mnagired
left a comment
mnagired
left a comment
There was a problem hiding this comment.
looks good, thanks for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sers
Adding fixes to avoid setup errors for Windows users #372